WIP: align both plugins with new backstage modern backend#158
Closed
DevelopmentCats wants to merge 2 commits intomainfrom
Closed
WIP: align both plugins with new backstage modern backend#158DevelopmentCats wants to merge 2 commits intomainfrom
DevelopmentCats wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the OAuth callback endpoint path from /api/auth/coder/oauth/callback to /api/coder/oauth/callback and adds support for Backstage's new backend system (v1.20+) while maintaining backward compatibility with the legacy backend system.
Key changes:
- Updates OAuth redirect URIs in both frontend and backend components to use the new
/api/coder/oauth/callbackpath - Introduces a new backend plugin module (
module.ts) for the new Backstage backend system with proper authentication policies - Adds comprehensive documentation for both new and legacy backend system setup
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
plugins/backstage-plugin-coder/src/components/CoderAuthForm/CoderAuthInputForm.tsx |
Updates frontend OAuth redirect URI to match new backend path |
plugins/backstage-plugin-coder-backend/src/service/router.ts |
Updates backend OAuth redirect URI construction to match new path |
plugins/backstage-plugin-coder-backend/src/module.ts |
New module implementing backend plugin for new Backstage system with auth policies |
plugins/backstage-plugin-coder-backend/src/index.ts |
Exports new module alongside legacy createRouter for backward compatibility |
plugins/backstage-plugin-coder-backend/package.json |
Adds @backstage/backend-plugin-api dependency for new backend system support |
plugins/backstage-plugin-coder-backend/README.md |
Documents setup instructions for both new and legacy backend systems |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for Backstage's new backend system (v1.20+) while keeping the old backend working too.
module.tsfile for new backend plugin system/api/auth/coderto/api/coder(the/api/auth/*path expects a full auth provider implementation, which Coder doesn't have yet)READMEwith instructions for both backend systems