Conversation
devcontainers-cli/README.md
Outdated
| ```tf | ||
| module "devcontainers-cli" { | ||
| source = "registry.coder.com/modules/devcontainers-cli/coder" | ||
| version = "release/claude-code/1.0.32" |
There was a problem hiding this comment.
Does release/claude-code/1.0.32 exist or is it an example?
There was a problem hiding this comment.
This one is enforced by the update-version.sh script - not sure if @matifali has more info here on why.
There was a problem hiding this comment.
This should probably be release/devcontainers-cli/1.0.0.
|
It might be nice to add Docker detection here as well and print a WARNING if |
|
Thanks @mafredri and @mtojek for the review - I added :
A question asked by Marcin about About naming, I'm up to keep |
mafredri
left a comment
There was a problem hiding this comment.
Minor suggestions but otherwise looking good, thanks for implementing support for multiple package managers! 🎉
devcontainers-cli/README.md
Outdated
| ```tf | ||
| module "devcontainers-cli" { | ||
| source = "registry.coder.com/modules/devcontainers-cli/coder" | ||
| version = "release/claude-code/1.0.32" |
There was a problem hiding this comment.
This should probably be release/devcontainers-cli/1.0.0.
mafredri
left a comment
There was a problem hiding this comment.
Some minor optional adjustments to improve the output, but nothing blocking on my side. Nice work!
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
|
PR Is ready, currently waiting for #426 to have easier versioning. |
|
All good for me with @matifali last changes ✅ Thanks. |
Related to this issue
Create a new module to install @devcontainers/cli using npm.