You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 15, 2025. It is now read-only.
This pull request updates the GitHub Actions workflow to enhance deployment flexibility by allowing it to trigger on specific tag patterns in addition to pushes to the main branch.
Workflow trigger update:
.github/workflows/deploy-registry.yaml: Added a tags condition under the push event to trigger the workflow for tags matching the pattern release/*/v* (e.g., release/module-name/v1.0.0).
Nit: I think we'll have quite a few started and cancelled builds, where a tag is pushed just after a merge.
We do not have any concurrency settings, so by default, all workflow runs run concurrently.
How do we fetch tags (is it git fetch --force --tags) during the build process? I don't want the latest pushed tag to an older commit to somehow exclude all later tags from the latest commit.
Without proper concurrency settings, module tags pushed to older commits can cause build issues:
A --- B --- C --- D ← Main branch
↑ ↑ ↑
| | |
module-a/v1.0.21 module-b/v1.2.0
|
↓
module-a/v1.1.0
(pushed later to an older commit)
Would this new tag (module-a/v1.1.0) pushed to an older commit cause the newer commit tag (module-b/v1.2.0) to be excluded from the latest build?
matifali
changed the title
ci: deploy on tag pushes
ci: deploy dev registry on tag pushes
Apr 22, 2025
No there wouldn't be any issues here. The release tag just says "the source for version vX.Y.Z of this module comes from this commit". It is completely valid for an older commit to be used as the source of truth for a newer version of a module.
There shouldn't be concurrency issues with fetching tags or anything either. The entire repo is cloned and all tags are present for every build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the GitHub Actions workflow to enhance deployment flexibility by allowing it to trigger on specific tag patterns in addition to pushes to the
mainbranch.Workflow trigger update:
.github/workflows/deploy-registry.yaml: Added atagscondition under thepushevent to trigger the workflow for tags matching the patternrelease/*/v*(e.g.,release/module-name/v1.0.0).