Skip to content

detail roadmap#83

Open
josurodriguez wants to merge 6 commits intomasterfrom
feature/74-roadmap-detail
Open

detail roadmap#83
josurodriguez wants to merge 6 commits intomasterfrom
feature/74-roadmap-detail

Conversation

@josurodriguez
Copy link
Contributor

@josurodriguez josurodriguez commented Oct 5, 2020

No description provided.

@vercel
Copy link

vercel bot commented Oct 5, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/coderhood/coderhood/8u3199ia8
✅ Preview: https://coderhood-git-feature-74-roadmap-detail.coderhood.vercel.app

@josurodriguez josurodriguez linked an issue Oct 5, 2020 that may be closed by this pull request
5 - Roadmap detail UI #74
Open
@josurodriguez josurodriguez self-assigned this Oct 5, 2020
@emalorenzo
Copy link
Collaborator

emalorenzo commented Oct 5, 2020 •
edited
Loading

📝Changed routes:

/ /roadmaps/[name]
Screenshot of /
(view full size)		 Screenshot of /roadmaps/[name]
(view full size)

Commit 83837fc (https://coderhood-git-feature-74-roadmap-detail.coderhood.now.sh).

emalorenzo
emalorenzo requested changes Oct 5, 2020
View reviewed changes
api/roadmaps/index.ts

export const getRoadmaps = () => {
return fetch<GetRoadmapsResponse>(
`${process.env.NEXT_PUBLIC_BASE_URL}/roadmaps`
Copy link
Collaborator

@emalorenzo emalorenzo Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

para que sacaste estas /? el build esta fallando por esto 🤔

components/CardTech.tsx Outdated
Copy link
Collaborator

@emalorenzo emalorenzo Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podes agregarle un interface con el tipado de esto?

components/CardTech.tsx Outdated
Copy link
Collaborator

@emalorenzo emalorenzo Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que cambiamos DM Sans por Poppins puede ser? preguntale a @SantyLorenzo sobre si seguir usando DM Sans por las dudas

components/button/Button.tsx Outdated
Copy link
Collaborator

@emalorenzo emalorenzo Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estos comentarios no son necesarios, el codigo es autoexplicativo en los nombres baseStyle, sizes y variants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emalorenzo emalorenzo emalorenzo requested changes

@emamasonn emamasonn Awaiting requested review from emamasonn

@SantyLorenzo-zz SantyLorenzo-zz Awaiting requested review from SantyLorenzo-zz

Assignees

@josurodriguez josurodriguez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 - Roadmap detail UI

2 participants

@josurodriguez @emalorenzo

Comments