Open
Conversation
Feature/simplified lint flow
* Improved ESLint rules, sorting, and using next rules * sending with error * testing husky * should fail * should be fixed now * added eslint fix command on pre-commit with husky * improved prettier config * merged tsconfig with jsconfig * removed unnecesary vscode config and added default project vscode settings * removed codesandbox config * lock dependencies * lint * fix mdx images Co-authored-by: Tomas Discoli <tomas.discoli@scale.com>
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/coderhood/coderhood/AyrqLi6NzGk2MtTsdZYjkJNW42GP |
tomasdisk
approved these changes
Jul 30, 2021
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| yarn eslint --fix |
Member
There was a problem hiding this comment.
No me gusta que te edite el codigo sin que te des cuenta 😕
como prefieras, no es nada grave igual xD
Suggested change
| yarn eslint --fix | |
| yarn eslint |
Contributor
Author
There was a problem hiding this comment.
Buen punto eh, tenes razon banco también que no hayan sorpresas
| "lint": "yarn prettier && yarn eslint", | ||
| "eslint": "eslint --max-warnings 20 'src/**/*.{js,jsx}' --ext jsconfig.json", | ||
| "eslint-fix": "eslint --fix 'src/**/*.{js,jsx}' --ext jsconfig.json", | ||
| "eslint": "eslint --max-warnings 50 'src/**/*.{js,jsx,ts,tsx}' --ext tsconfig.json", |
Member
There was a problem hiding this comment.
50 👀
Lol cada vez mas grande!
Contributor
Author
There was a problem hiding this comment.
Jajaja era para que me deje pushear y me colgué. Lo tengo que sacar 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.