Feature: Individual Art and Art Showcase Page - Issue #8 + #40#137
Open
Feature: Individual Art and Art Showcase Page - Issue #8 + #40#137
Conversation
…/game-dev into issue-8/art-page
…flict Issue 8 resolve merge conflict
-Rather than name and pronouns being part of the same rectangle, they are their own independent blocks that will wrap if appropriate - Added placeholder text for committee portrait pronouns, where it will say "No Pronouns" if the pronouns attribute is blank. We can definitely change if needed
- Removed ternary logic for pronouns which showed a placeholder of "No Pronouns" if a committee member's pronouns was empty. This was simply replaced with empty:hidden, so the pronoun element just won't display if they're empty
… using 3.14, which is incompatible with django 5.1.15
Co-authored-by: James Lee <82937700+SafetyInObscurity@users.noreply.github.com>
Co-authored-by: Sam Jackson <114900452+samjjacko@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Frontend
Created Frontend page for Art Showcase and Individual Art Page.
Behaviour:
Art Showcase Page: If there is no Artwork or backend app does not respond, the page will use the placeholder image instead and all interactive features (flip card, show info of the featured art, etc.) are disabled. Exactly 3 featured artworks displayed.
Expected result:
Backend
ArtShowcase,ArtContributorandArttables and 2 API responses:arts/featured: returns the 3 featured arts as chosen by admin (if more than 3 arts chosen in the ArtShowcase table, the api will return the first 3 arts - ordered by art id). Example API response:arts/{id}: returns specific art withid:ArtModelTest: 6 testsArtContributorModelTest: 6 testsArtShowcaseModelTest: 6 testsChange Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
The documentation is in issue art documentation #99 branch
Other Information
[Is there anything in particular in the review that I should be aware of?]
When a new artwork is added, the uploaded image will be saved at
/server/media/artRelated issue