Open
Conversation
…orm to components, adjusted names to not be conflicting
…fit modal, renamed unused repairAttemptForm
…into issue-198-Repair_attempt_full-screen_modal
…into issue-198-Repair_attempt_full-screen_modal
…into issue-198-Repair_attempt_full-screen_modal
…into issue-198-Repair_attempt_full-screen_modal
justinliangg
requested changes
Feb 25, 2024
Collaborator
justinliangg
left a comment
justinliangg
left a comment
There was a problem hiding this comment.
Nice work!
For mobile devices, could you make the modal take the entire screen instead of still being a modal.
Example:
…into issue-198-Repair_attempt_full-screen_modal
…into issue-198-Repair_attempt_full-screen_modal
Collaborator
Author
It's still a modal but it takes about the full width of the screen, is that good or should it be a separate page on mobile view? The modal uses headlessui's dialog component and it seems that cant take up the whole screen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]