Added "tc-" Prefix to CSS Classes#11
Open
marvinscharle wants to merge 1 commit intocodinova-tech:masterfrom
Open
Added "tc-" Prefix to CSS Classes#11marvinscharle wants to merge 1 commit intocodinova-tech:masterfrom
marvinscharle wants to merge 1 commit intocodinova-tech:masterfrom
Conversation
- table-selector -> tc-table-drawer-selector - table-row -> tc-table-drawer-row - table-cell-container -> tc-table-drawer-cell-container - table-cell -> tc-table-drawer-cell
SebastianTroc
approved these changes
Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the following css classes, prefixed them with "tc-table-drawer-" to avoid naming conflicts with other CSS class names.
Reason: The class names
table-rowis very generic and is very likely to produce naming conflicts with other style systems / JS modules. By adding the prefixtc-table-drawer-the name is more specific to this module, since other classes were already prefixed withtc-and therefore less likely to produce name conflicts.