Conversation
🟡 Heimdall Review Status
|
frolic
force-pushed
the
holic/local-deploys
branch
from
126f58a to
ed163c8
Compare
| address constant EXPECTED_FACTORY = 0x0BA5ED0c6AA8c49038F819E587E2633c4A9F428a; | ||
| // cast code 0x914d7Fec6aaC8cd542e72Bca78B30650d45643d7 --rpc-url https://mainnet.base.org | ||
| bytes constant SAFE_SINGLETON_FACTORY_CODE = | ||
| hex"7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe03601600081602082378035828234f58015156039578182fd5b8082525050506014600cf3"; |
There was a problem hiding this comment.
ideally SafeSingletonDeployer would export this or a method containing the vm.etch logic, but hardcoding it here for now
happy to open a PR over there too if this sounds reasonable!
There was a problem hiding this comment.
yeah good idea to export
There was a problem hiding this comment.
or alternatively, maybe we should just have a new function like, "deployAnvil"? which uses etch and doesn't have to expose
There was a problem hiding this comment.
works for me, should I open a PR?
There was a problem hiding this comment.
went ahead and opened one: wilsoncusack/safe-singleton-deployer-sol#2
| // Set the deployer code if it's not already on the chain. | ||
| if (SafeSingletonDeployer.SAFE_SINGLETON_FACTORY.code.length == 0) { |
There was a problem hiding this comment.
this check could alternatively be
| // Set the deployer code if it's not already on the chain. | |
| if (SafeSingletonDeployer.SAFE_SINGLETON_FACTORY.code.length == 0) { | |
| // Set the deployer code when running this on Anvil | |
| if (block.chainid == 31337) { |
|
Review Error for DashaBochkar @ 2024-11-02 22:18:27 UTC |
|
Review Error for Jakeshellybase @ 2024-12-11 08:02:04 UTC |
|
Review Error for Jakeshellybase @ 2024-12-21 12:34:28 UTC |
4 participants
--verifyflag only whenETHERSCAN_API_KEYis setthis allows for running
make deploywith anvil