Skip to content

Fix typo in "Breaking Change" docs #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaelollivier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo in "Breaking Change" docs #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ which got updated to:
```ruby
class MyWorkflow < Temporal::Workflow
def execute
Activity1.execute!
ActivityOld1.execute!

if workflow.has_release?(:fix_1)
ActivityNew1.execute!
Expand All @@ -519,7 +519,7 @@ class MyWorkflow < Temporal::Workflow
if workflow.has_release?(:fix_1)
ActivityNew2.execute!
else
ActivityOld.execute!
ActivityOld2.execute!
end

if workflow.has_release?(:fix_2)
Expand All @@ -534,7 +534,7 @@ end
If the release got deployed while the original workflow was waiting on a timer, `ActivityNew1` and
`ActivityNew2` won't get executed, because they are part of the same change (same release_name),
however `ActivityNew3` will get executed, since the release wasn't yet checked at the time. And for
every new execution of the workflow — all new activities will get executed, while `ActivityOld` will
every new execution of the workflow — all new activities will get executed, while `ActivityOld2` will
not.

Later on you can clean it up and drop all the checks if you don't have any older workflows running
Expand Down