Remove unused throwOnMissingSetterMethod configuration variable #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

grantcopley merged 2 commits into next from copilot/remove-unused-config-variable

Nov 26, 2025

Contributor

Copilot AI commented Nov 26, 2025 •

edited

Loading

The throwOnMissingSetterMethod configuration was defined but never implemented. The _applyUpdates() method directly modifies variables.data instead of calling setter methods, making this setting ineffective.

Changes:

Removed throwOnMissingSetterMethod from ModuleConfig.cfc settings
Removed corresponding documentation from .github/copilot-instructions.md

No functional impact—this configuration had no effect on runtime behavior.

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove unused throwOnMissingSetterMethod configuration variable</issue_title>
<issue_description> The throwOnMissingSetterMethod configuration variable is not used anywhere in the codebase. It was planned to be used but was never actually implemented.

The current implementation directly updates variables.data in the _applyUpdates() method rather than calling setter methods, so this configuration would have no effect even if set to true.

We can safely remove this configuration variable unless you plan to implement this functionality in the future.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Remove unused throwOnMissingSetterMethod configuration variable #247

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


          Initial plan

ea9951f

Copilot AI assigned Copilot and grantcopley

Copilot started work on behalf of grantcopley

November 26, 2025 00:04


          Remove unused throwOnMissingSetterMethod configuration variable

cdef8d2

Co-authored-by: grantcopley <1197835+grantcopley@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Remove unused throwOnMissingSetterMethod configuration variable~~ Remove unused throwOnMissingSetterMethod configuration variable

Copilot AI requested a review from grantcopley

November 26, 2025 00:11

Copilot finished work on behalf of grantcopley

November 26, 2025 00:11

grantcopley approved these changes

View reviewed changes

github-actions bot commented Nov 26, 2025 •

edited

Loading

lucee@5 Test Results

293 tests ±0 271 ✅ ±0 5s ⏱️ ±0s
8 suites ±0 22 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit cdef8d2. ± Comparison against base commit 7d3adf2.

♻️ This comment has been updated with latest results.

github-actions bot commented Nov 26, 2025 •

edited

Loading

lucee@6 Test Results

293 tests ±0 271 ✅ ±0 4s ⏱️ ±0s
8 suites ±0 22 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit cdef8d2. ± Comparison against base commit 7d3adf2.

♻️ This comment has been updated with latest results.

github-actions bot commented Nov 26, 2025 •

edited

Loading

boxlang-cfml@1 Test Results

293 tests +293 275 ✅ +275 11s ⏱️ +11s
8 suites + 8 18 💤 + 18
1 files + 1 0 ❌ ± 0

Results for commit cdef8d2. ± Comparison against base commit 7d3adf2.

♻️ This comment has been updated with latest results.

github-actions bot commented Nov 26, 2025 •

edited

Loading

adobe@2023 Test Results

293 tests ±0 271 ✅ ±0 7s ⏱️ ±0s
8 suites ±0 22 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit cdef8d2. ± Comparison against base commit 7d3adf2.

♻️ This comment has been updated with latest results.

github-actions bot commented Nov 26, 2025 •

edited

Loading

adobe@2025 Test Results

293 tests +293 271 ✅ +271 6s ⏱️ +6s
8 suites + 8 22 💤 + 22
1 files + 1 0 ❌ ± 0

Results for commit cdef8d2. ± Comparison against base commit 7d3adf2.

♻️ This comment has been updated with latest results.

grantcopley marked this pull request as ready for review

November 26, 2025 00:21

grantcopley merged commit 877042a into next

20 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet