Create job in specified view#16
Open
jamesdonnelly2 wants to merge 2 commits intocolinnewell:masterfrom
Open
Conversation
Create job in specified view
Owner
|
That changes the method signature in a way that would make everyone else change their code, and doesn't allow for simply adding the job without specifying the view. If you'd like this included in the module make the parameter optional (ideally with a hashref so that other extensions can be added later) or a new method. Additionally the documentation needs updating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed this change to help me organise automatically created jobs into our pre-existing view structure.