Skip to content

fixing lowercase issue on loader of Hero.js to make it works on linux… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cesarpachon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixing lowercase issue on loader of Hero.js to make it works on linux… #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29c4b6a
fixing lowercase issue on loader of Hero.js to make it works on linux…
cesarpachon Dec 29, 2015
c852dc9
fixing bug when turning character
cesarpachon Dec 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/web/js/kaiopua/core/Character.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,6 @@
rotate = movement.rotate,
rotateFacingDirection = rotate.facingDirection,
forwardBack;

// handle state property

if ( state.hasOwnProperty( propertyName ) ) {
Expand Down Expand Up @@ -715,7 +714,7 @@
state.moving = false;

}

// update movement

moveDir.z = state.movingHorizontal ? 1 : 0;
Expand All @@ -724,7 +723,6 @@

rotateTurnAngleDelta = ( state.right === 1 ? -state.right : state.left ) * rotate.turnSpeed;
rotateFacingAngleDelta = _VectorHelper.signed_angle_between_coplanar_vectors( rotateFacingDirectionLast, rotateFacingDirection, rotateAxis ) * rotateLerpDelta;

// if moving

if ( state.movingHorizontal === true ) {
Expand All @@ -747,7 +745,10 @@
// rotate by direction angle change

if ( rotateFacingAngleDelta !== 0 ) {


//maybe need to convert to degrees..
rotateFacingAngleDelta = rotateFacingAngleDelta * Math.PI /180;

rotateFacingAngleTarget = _MathHelper.degree_between_180( rotate.facingAngle + rotateFacingAngleDelta );
rotateFacingAngleDeltaShortest = _MathHelper.shortest_rotation_between_angles( rotate.facingAngle, rotateFacingAngleTarget );
rotateDelta.setFromAxisAngle( rotateAxis, rotateFacingAngleDeltaShortest );
Expand Down Expand Up @@ -1000,4 +1001,4 @@

}

} ( KAIOPUA ) );
} ( KAIOPUA ) );
4 changes: 2 additions & 2 deletions src/web/js/kaiopua/sections/Launcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"js/kaiopua/env/Skybox.js",
"js/kaiopua/env/Water.js",
"js/kaiopua/utils/ObjectHelper.js",
{ path: shared.pathToAsset + "hero.js", type: 'model' },
{ path: shared.pathToAsset + "Hero.js", type: 'model' },
shared.pathToAsset + "skybox_world_posx.jpg",
shared.pathToAsset + "skybox_world_negx.jpg",
shared.pathToAsset + "skybox_world_posy.jpg",
Expand Down Expand Up @@ -355,4 +355,4 @@

}

} ( KAIOPUA ) );
} ( KAIOPUA ) );