Fix thread safety in Godot callback trampolines#17
Closed
imperiumplay wants to merge 4 commits intomainfrom
Closed
Fix thread safety in Godot callback trampolines#17imperiumplay wants to merge 4 commits intomainfrom
imperiumplay wants to merge 4 commits intomainfrom
Conversation
Member
|
(EDITED: Moved comment to original issue: #8 (comment)) |
Collaborator
Author
|
Closing this, need testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix crash when callbacks are invoked from worker threads.
The callback trampolines were calling Godot API functions directly from the native SDK's worker thread, causing crashes with "can't call propagate_notification() from this thread" errors.
Changed to use
call_deferredto queue callback execution on the main thread, matching the pattern already used for signal emission incolyseus_client.c.Affects all platforms.
Not tested on local as I don't have linux machine myself but it passes our CI test cases: https://github.com/colyseus/native-sdk/actions/runs/22501056430