remove defaultProps from CometChatBadge, use default params instead#71
Open
kyleshevlin wants to merge 2 commits intocometchat:v4from
Open
remove defaultProps from CometChatBadge, use default params instead#71kyleshevlin wants to merge 2 commits intocometchat:v4from
defaultProps from CometChatBadge, use default params instead#71kyleshevlin wants to merge 2 commits intocometchat:v4from
Conversation
`defaultProps` will be deprecated for function components soon. This uses default parameters instead and suppresses a React Native warning.
kyleshevlin
commented
Mar 19, 2025
| count= 0, | ||
| style: propsStyle= new BadgeStyle({}), | ||
| } = props; | ||
| export const CometChatBadge = ({ count = 0, style = new BadgeStyle({}) }: CometChatBadgeProps) => { |
Author
There was a problem hiding this comment.
Technically, I made this change first. You don't need the props object for anything else, so just destructure inline. Plus, the correct spacing usage for the =.
kyleshevlin
commented
Mar 19, 2025
| */ | ||
| interface CometChatBadgeProps { | ||
| count: number; | ||
| count?: number; |
Author
There was a problem hiding this comment.
Your type is either incorrect, or you don't need to set a default count. It's one or the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaultPropswill be deprecated for function components soon. This uses default parameters instead and suppresses a React Native warning.