Handle errors while uploading emotes#822
Open
Grafcube wants to merge 1 commit intocommetchat:mainfrom
Open
Conversation
Wait and retry when homeserver is rate limiting and bail if any other error occurs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch handles errors when uploading emotes. Earlier, the upload indicator would just freeze and it wouldn't be possible to upload any more emotes without restarting commet. With this change, if the homeserver responds with limit exceeded, the task is paused for a few seconds and then tries again. If any other error occurs, that image is skipped and the next one is tried.