Skip to content

Fix replies not being parsed correctly #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Airyzz merged 2 commits into from
Mar 12, 2026
Merged

Fix replies not being parsed correctly #831

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0880cc
Update matrix_timeline_event_mixin_related.dart
Airyzz Mar 12, 2026
bdf9f3f
Update matrix_timeline_event_mixin_related.dart
Airyzz Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions commet/lib/client/matrix/timeline_events/matrix_timeline_event_mixin_related.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,21 @@ mixin MatrixTimelineEventRelated on MatrixTimelineEvent
String? get relatedEventId => _getRelatedEventId();

@override
EventRelationshipType? get relationshipType =>
switch (event.relationshipType) {
"m.in_reply_to" => EventRelationshipType.reply,
"m.thread" => _getThreadRichResponseId() != null
? EventRelationshipType.reply
: null,
_ => null,
};
EventRelationshipType? get relationshipType {
var result = switch (event.relationshipType) {
"m.in_reply_to" => EventRelationshipType.reply,
"m.thread" =>
_getThreadRichResponseId() != null ? EventRelationshipType.reply : null,
_ => null,
};

if (result != null) return result;

var reply = event.inReplyToEventId();
if (reply != null) return EventRelationshipType.reply;

return null;
}

String? _getThreadRichResponseId() {
var rel = event.content["m.relates_to"] as Map<String, dynamic>?;
Expand All @@ -41,6 +48,9 @@ mixin MatrixTimelineEventRelated on MatrixTimelineEvent
return _getThreadRichResponseId();
}

var reply = event.inReplyToEventId();
if (reply != null) return reply;

return event.relationshipEventId;
}
}
Loading