Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have access to an MacOS computer (and iPads), so I thought I could have a stab at getting the build working. I've been working a lot with dart and flutter for my research platform, and have had to deal with some similar issues (with the exception of rust libs, I've been using C FFI native libs).
I'm looking for some feedback on this PR, both in terms of scope and how you would like to have it chunked.
What this PR does already:
What doesn't work yet:
vodozemac/flutter_vodozemaclibrary, and I haven't yet figured out why - the build does make the lib, but ends up outputting it asflutter_vodozemac(not, e.g.libflutter_vodozemac.dylib), but I made a quick test pointing directly to the lib file and it still didn't find it. I would need to spend more time investigating.Untested yet:
I guess my main question before turning this into a fully-fledged PR is:
maingithub version of the applemedia_kit_*packages fixes the main problem that broke the build, obviously pointing to the head of a repo is dangerous. Would you prefer:any is fine for me, once I know I can update the PR.
Thanks!
Edit: I wanted to make it clear that none of the changes in the PR, nor the text above used generative AI.