Skip to content

Conversation

@jcurtis2
Copy link
Collaborator

@jcurtis2 jcurtis2 commented Nov 4, 2024

  • Create aero_data from TChem using getters
    • Get number of aerosol species to allocate aero_data sizes
    • Get species name for each species
    • Get density for each species
    • Get molecular weight for each species
    • Get kappa for each species
  • Set the number concentrations from 1:n_part, and 0 for n_part+1 to maximum
  • Set the particle species masses in the state vector
  • Reconstruct the particle masses from TChem state vector.

Testing

  • Test CPU code against TChem result
  • Test GPU code against TChem result
  • Fix tchem tests

@jcurtis2 jcurtis2 self-assigned this Nov 4, 2024
@jcurtis2 jcurtis2 marked this pull request as ready for review May 28, 2025 16:27
@jcurtis2 jcurtis2 requested a review from mwest1066 May 28, 2025 16:27
@slayoo
Copy link
Collaborator

slayoo commented Aug 28, 2025

FWIW, perhaps related warning caught on PyPartMC CI:

      /home/runner/work/PyPartMC/PyPartMC/gitmodules/partmc/src/tchem_interface.F90:23:23:
      
         11 |   use pmc_aero_data
            |      2
      ......
         23 |   subroutine initialize(arg_chemfile, arg_aerofile, arg_numericsfile, &
            |                       1
      Warning: Type mismatch in argument 'this' (CLASS(aero_rep_data_t)/CHARACTER(1)) between (1) and (2)

@slayoo
Copy link
Collaborator

slayoo commented Sep 16, 2025

closing and reopening to trigger codecov analysis

@slayoo slayoo closed this Sep 16, 2025
@slayoo slayoo reopened this Sep 16, 2025
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@2341ef4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/tchem_interface.F90 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #204   +/-   ##
=========================================
  Coverage          ?   76.84%           
=========================================
  Files             ?       55           
  Lines             ?     9223           
  Branches          ?        0           
=========================================
  Hits              ?     7087           
  Misses            ?     2136           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants