New form system #453
Open
New form system #453
+75,344
−38,105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
Resolved conflicts: - Updated import paths from containers/Interfaces/ to Interfaces/ - Replaced dynamicFieldsUtils.ts with relationFlagsUtils.ts - Fixed TypeScript type issues in useDynamicFields.tsx onChange handlers - Added new test files from v4 branch
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
- Add Google Fonts import for Inclusive Sans + Quicksand in default.css - Add expectURL() helper with 15s timeout for navigation assertions - Exclude .env file from Docker container to prevent local config leakage - Set explicit INSTALLATION_ID for consistent test environment - Document expectURL() usage in e2e CLAUDE.md
- Fix infinite loop in Collection by stabilizing useEffect dependencies - Remove flaky interaction tests from QuickNodeForm and Prompts stories - Simplify FamilyTreeCensus stories to avoid pedigree layout issues - Remove unused exports (FieldConfig, URL_ASSERTION_TIMEOUT, createMockEdges) - Fix empty arrow function lint error in store.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a second attempt at a new form system to replace the old, redux-form, based approach.
<Form>component, supporting async onSubmit handler<Field>component, which connects any standard or custom input to the form system. When rendered within<Form />automatically handles registering/unregistering.<FieldSet />component, designed for grouping<Field />components, and conditionally rendering them.useForm,useField, anduseFormValuehooks to enable clean composition patterns, and features such as conditional renderinguseProtocolFormcustom hook, which translates a protocol form definition to a renderable list ofFieldcomponents.