Validation extension #286
Open
Validation extension #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces OSCAL validation via the available json schema (from https://github.com/usnistgov/OSCAL/releases/tag/v1.1.3). It takes the produced errors & turns them into field: error as required.
Note it is only implemented for a few components currently, and should be extended for the rest. See assessment plan & assessment results files for how to implement. Some test data may need to be extended to pass validation for some tests.
I've reached up to POA&Ms, where there exists tests for validating back matter with empty resources for example. I think test acceptance should change since the json schema specifies there must be at least 1 resource present