fix(BCH-1108): fix capabilities creation on component definition #314
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
There was a problem hiding this comment.
Pull request overview
This pull request modifies the CreateCapabilities endpoint to handle a single capability instead of an array of capabilities. The change simplifies the endpoint from batch processing to single-item creation.
Changes:
- Modified request binding from array (
[]oscalTypes_1_1_3.Capability) to single capability (oscalTypes_1_1_3.Capability) - Changed validation logic to validate a single capability instead of iterating over an array
- Simplified relational model conversion to handle one capability instead of multiple
- Changed response type from
GenericDataListResponsetoGenericDataResponse
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| relationalCapability := relational.Capability{} | ||
| relationalCapability.UnmarshalOscal(capability) | ||
| relationalCapability.ComponentDefinitionId = id | ||
| newCapability = relationalCapability |
There was a problem hiding this comment.
The redundant variable assignment is unnecessary. The variable 'newCapability' is declared on line 1636, then 'relationalCapability' is created on line 1637, populated on lines 1638-1639, and then assigned to 'newCapability' on line 1640. You can simplify this by using 'newCapability' directly instead of creating an intermediate 'relationalCapability' variable.
| relationalCapability := relational.Capability{} | |
| relationalCapability.UnmarshalOscal(capability) | |
| relationalCapability.ComponentDefinitionId = id | |
| newCapability = relationalCapability | |
| newCapability.UnmarshalOscal(capability) | |
| newCapability.ComponentDefinitionId = id |
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
|
actually - we don;t need this to fix the issue. Better to establish routes in api are batch - first. |
No description provided.