-
Notifications
You must be signed in to change notification settings - Fork 2
feat: put endpoint for POAM local-defs #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a PUT endpoint for POA&M local-definitions, with accompanying serialization tweaks to preserve explicitly-empty arrays, plus integration tests and updated Swagger docs.
Changes:
- Add
PUT /oscal/plan-of-action-and-milestones/{id}/local-definitionshandler and route registration. - Update POA&M local-definitions marshaling to emit
[]when arrays were explicitly set empty (vs omitted). - Add integration tests and update generated Swagger artifacts for the new endpoint.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/service/relational/plan_of_action_and_milestones.go | Marshal local-definitions to distinguish omitted vs explicitly-empty arrays. |
| internal/api/handler/oscal/plan_of_action_and_milestones.go | Register new PUT route and implement UpdateLocalDefinitions + helpers. |
| internal/api/handler/oscal/plan_of_action_and_milestones_integration_test.go | Add integration coverage for GET/PUT local-definitions behaviors. |
| docs/swagger.yaml | Document the new PUT local-definitions endpoint. |
| docs/swagger.json | Generated swagger JSON updated for the new endpoint. |
| docs/docs.go | Generated swagger template updated for the new endpoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/api/handler/oscal/plan_of_action_and_milestones_integration_test.go
Show resolved
Hide resolved
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.