Skip to content

Conversation

@gusfcarvalho
Copy link
Contributor

No description provided.

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copilot AI review requested due to automatic review settings January 26, 2026 10:27
@gusfcarvalho gusfcarvalho changed the title feat: put endpoint for poem local-defs feat: put endpoint for POAM local-defs Jan 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a PUT endpoint for POA&M local-definitions, with accompanying serialization tweaks to preserve explicitly-empty arrays, plus integration tests and updated Swagger docs.

Changes:

  • Add PUT /oscal/plan-of-action-and-milestones/{id}/local-definitions handler and route registration.
  • Update POA&M local-definitions marshaling to emit [] when arrays were explicitly set empty (vs omitted).
  • Add integration tests and update generated Swagger artifacts for the new endpoint.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
internal/service/relational/plan_of_action_and_milestones.go Marshal local-definitions to distinguish omitted vs explicitly-empty arrays.
internal/api/handler/oscal/plan_of_action_and_milestones.go Register new PUT route and implement UpdateLocalDefinitions + helpers.
internal/api/handler/oscal/plan_of_action_and_milestones_integration_test.go Add integration coverage for GET/PUT local-definitions behaviors.
docs/swagger.yaml Document the new PUT local-definitions endpoint.
docs/swagger.json Generated swagger JSON updated for the new endpoint.
docs/docs.go Generated swagger template updated for the new endpoint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gusfcarvalho gusfcarvalho merged commit 1111abc into main Jan 27, 2026
10 checks passed
@gusfcarvalho gusfcarvalho deleted the gc-feat-poam-local-def-routes branch January 27, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants