-
Notifications
You must be signed in to change notification settings - Fork 1
feat: implements codeowners, teams, PR reviews and Comments #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7263780
feat: implements codeowners, teams, PR reviews and Comments for polic…
gusfcarvalho 1348cec
feat: adds branch protection rules
gusfcarvalho 7a5bd6e
fix: copilot review
gusfcarvalho 2086d94
fix: copilot issues
gusfcarvalho d54e781
fix: final review
gusfcarvalho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/google/go-github/v71/github" | ||
| ) | ||
|
|
||
| var defaultCodeOwnerPaths = []string{ | ||
| "CODEOWNERS", | ||
| ".github/CODEOWNERS", | ||
| "docs/CODEOWNERS", | ||
| } | ||
|
|
||
| // FetchCodeOwners attempts to retrieve the CODEOWNERS file for the repository. | ||
| // If the file cannot be found or is inaccessible due to permissions, the function | ||
| // returns nil and logs the reason so policy evaluation can proceed with an empty value. | ||
| func (l *GithubReposPlugin) FetchCodeOwners(ctx context.Context, repo *github.Repository) (*github.RepositoryContent, error) { | ||
| owner := repo.GetOwner().GetLogin() | ||
| name := repo.GetName() | ||
|
|
||
| for _, path := range defaultCodeOwnerPaths { | ||
| file, _, resp, err := l.githubClient.Repositories.GetContents(ctx, owner, name, path, nil) | ||
| if err != nil { | ||
| if resp != nil && resp.StatusCode == 404 { | ||
| continue | ||
| } | ||
| if isPermissionError(err) { | ||
| return nil, nil | ||
| } | ||
| return nil, err | ||
| } | ||
| if file != nil { | ||
| return file, nil | ||
| } | ||
| } | ||
|
|
||
| return nil, nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function comment at line 17 states that it "logs the reason" when the file cannot be found or is inaccessible, but the function doesn't actually log anything when returning nil (lines 29, 38). Consider either updating the comment to reflect the actual behavior, or add logging when permission errors occur or when no CODEOWNERS file is found.