Update log reading to allow reading python2 pickled slogs#173
Open
cs-hall wants to merge 1 commit intocompmem:masterfrom
Open
Update log reading to allow reading python2 pickled slogs#173cs-hall wants to merge 1 commit intocompmem:masterfrom
cs-hall wants to merge 1 commit intocompmem:masterfrom
Conversation
Change Unpickler encoding to 'latin1'. This should only change things when reading in slog files encoded with python 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Unpickler encoding to 'latin1'. This should only change things when reading in slog files encoded with python 2.
I had trouble confirming this rigorously and figured someone here may know of the top of their head. This fixed my issue in reading in an old experiment, however, I haven't check if it works for reading in new experiments (and I wasn't sure where to find a new experiment to test on).