Skip to content

Fix: Make candidate account creation case insensitive and check for d… #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saikumarvasa100-hash wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Make candidate account creation case insensitive and check for d… #599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion hknweb/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,19 @@ def email_to_username(email: str) -> str:
"username", flat=True
)
)

# Get existing emails
emails = []
for row in rows:
email = row["Berkeley email"]
if email:
emails.append(email)

existing_emails = set(
User.objects.filter(email__in=emails).values_list(
"email", flat=True
)
)

# Setup account provisioning utils
# Get candidate group to add users to
Expand All @@ -241,7 +254,7 @@ def generate_password() -> str:
email_information = []
for row in rows:
# If username is None or already exists, skip provisioning
if (row["username"] is None) or (row["username"] in existing_usernames):
if (row["username"] is None) or (row["username"].lower() in existing_usernames) or (row["Berkeley email"] in existing_emails):
continue

# Generate a password
Expand Down