Skip to content

Conversation

@veitveit
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a constraints feature to the vsclust fuzzy c-means clustering algorithm, allowing users to fix certain membership values to zero. This enables excluding specific features from being assigned to particular clusters.

Key Changes:

  • Added optional constraints parameter (logical matrix) to clustering functions that forces membership values to zero for constrained feature-cluster pairs
  • Updated C++ implementation with constraint-aware versions of distance and membership update functions
  • Added comprehensive test coverage for constraint functionality

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/vsclust_algo.cpp Implements constraint logic in C++ fuzzy c-means algorithm with overloaded distance/membership functions
src/RcppExports.cpp Updates exported C++ function signatures to include constraints parameter
R/RcppExports.R Adds R wrapper handling for constraints with default empty matrix initialization
R/RunClustering.R Adds constraints validation and integrates constraint parameter into clustering functions
R/WrapperFuncs.R Propagates constraints parameter through wrapper functions and removes unnecessary clusterExport calls
tests/testthat/test-HelperFuncs.R Adds test cases validating constraint behavior in both vsclust_algorithm and ClustComp
man/*.Rd Updates documentation to describe constraints parameter and fixes existing typos
..Rcheck/00check.log Build log showing R version update (informational only)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

veitveit and others added 5 commits November 23, 2025 15:37
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@veitveit veitveit merged commit c660127 into master Nov 24, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants