Verbosity and Examples updates as well as some functional updates#102
Open
cjpalmer wants to merge 8 commits intocompwiz32:masterfrom
Open
Verbosity and Examples updates as well as some functional updates#102cjpalmer wants to merge 8 commits intocompwiz32:masterfrom
cjpalmer wants to merge 8 commits intocompwiz32:masterfrom
Conversation
Verbosity in Test-SRVRecords
Verbosity updates for various function. Some functionality improvements for consistency reasons as well
Added additional examples, modified build to include sample script, f…
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great module. I started testing it in my environment and found a few issues to clean up and while trying to figure it out, I found that some of the functions were not verbose enough for easy discovery. I started updated functions with verbosity and then additional help (added help to some, extended help on others). I also found the need to update the functionality of Test-ExternalDNSServers because it assumes that outbound ping is allowed. That is not always the case so I added a fallback test that would verify TCP-53 (with the assumption the UDP-53 would work as well) and allowed that to pass the test. I also extended the sample script for creating the scheduled tasks and then updated the build to include that script with the module.
I hope you find my additions and updates helpful.