Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18842847813. Examine the logs at this URL for more detail. |
|
Same as in #1664: No idea why xsimd doesn't get found anymore, it's definitely present in $PREFIX: arrow-cpp-feedstock/recipe/meta.yaml Line 95 in 7f0f076 |
Trying leaving |
|
We seem to require AVX2 unconditionally for that file but the The cc @AntoinePrv FYI |
|
Sounds like a bug to me if arrow-cpp-feedstock/recipe/build.sh Line 93 in 7f0f076 causes anything higher than the absolutely lowest baseline in terms of necessary CPU features. |
|
Yes, seems like a bug to me if the file requires AVX2 at compile time shouldn't only use the |
|
This might be a slightly different issue from apache/arrow#47946 Here we have |
|
I think it's the exact same issue. |
|
@conda-forge/arrow-cpp Anyone feels like trying this patch here: From b66e127fe2278b3c28a9281a4ac2e18b6383e6da Mon Sep 17 00:00:00 2001
From: AntoinePrv <AntoinePrv@users.noreply.github.com>
Date: Mon, 27 Oct 2025 10:25:58 +0100
Subject: [PATCH] Change xsimd inclusion criterion
---
cpp/src/arrow/util/byte_stream_split_internal.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cpp/src/arrow/util/byte_stream_split_internal.h b/cpp/src/arrow/util/byte_stream_split_internal.h
index 70f9b87d6c..1ba2d5335b 100644
--- a/cpp/src/arrow/util/byte_stream_split_internal.h
+++ b/cpp/src/arrow/util/byte_stream_split_internal.h
@@ -29,7 +29,9 @@
#include <cstdint>
#include <cstring>
-#if defined(ARROW_HAVE_NEON) || defined(ARROW_HAVE_SSE4_2)
+// ARROW_HAVE_RUNTIME_SSE4_2 is used on x86-64 to include ARROW_HAVE_SSE4_2 and
+// ARROW_RUNTIME_SIMD_LEVEL != NONE.
+#if defined(ARROW_HAVE_NEON) || defined(ARROW_HAVE_RUNTIME_SSE4_2)
# include <xsimd/xsimd.hpp>
# define ARROW_HAVE_SIMD_SPLIT
#endif
--
2.51.0
|
|
Thanks @AntoinePrv, that seems to have fixed things! 🥳 There's one last problem on osx-64 though - I don't know why it picks up the wrong compiler during the testing phase. It runs immediately after the main CMake build, and we haven't reconfigured anything, much less the compilers |
|
@h-vetinari I don't know, but this is the part that tries to extract a traceback after a test crashed. Edit: well, more precisely, it processes a log file with |
No, it's unrelated. |
|
CI seems good now |
h-vetinari
left a comment
There was a problem hiding this comment.
Thanks for the help on this! 🙏
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/18777272011 - please use this URL for debugging.