Merged
Conversation
…onfirm Dialog, Loading Button, and main registry
…ertProvider and ConfirmProvider components, and enhance README with usage examples
Greptile SummaryThis PR migrates the component registry from Key changes:
Issues found:
Confidence Score: 3/5
|
| Filename | Overview |
|---|---|
| registry/radix-nova/button.tsx | New button component with incorrect import statement from radix-ui instead of @radix-ui/react-slot |
| registry/radix-nova/dialog.tsx | New dialog component with incorrect import from radix-ui instead of @radix-ui/react-dialog |
| components/ui/alert-dialog.tsx | Updated styling with incorrect import from radix-ui instead of @radix-ui/react-alert-dialog |
| components/ui/label.tsx | Minor updates with incorrect import from radix-ui instead of @radix-ui/react-label |
| components/ui/button.tsx | Changed to re-export from @/components/c-ui/button which resolves via tsconfig path mapping |
| tsconfig.json | Added path mapping for @/components/c-ui/* with fallback to registry/radix-nova |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[components.json<br/>style: radix-nova] --> B[tsconfig.json<br/>Path Mapping]
B --> C[Path: @/components/c-ui/*]
C --> D[components/c-ui/*<br/>if exists]
C --> E[registry/radix-nova/*<br/>fallback]
E --> F[button.tsx]
E --> G[alert-provider.tsx]
E --> H[confirm-provider.tsx]
E --> I[confirm-dialog.tsx]
E --> J[loading-button.tsx]
E --> K[dialog.tsx]
G --> L[AlertDialogProvider<br/>useAlert hook]
H --> M[ConfirmDialogProvider<br/>useConfirm hook]
N[components/ui/button.tsx] -.re-export.-> C
F --> N
O[registry.json] --> P[public/r/radix-nova/*.json]
P --> Q[Hosted Registry<br/>coneno.github.io]
Last reviewed commit: 4c92259
Additional Comments (2)
Prompt To Fix With AIThis is a comment left during a code review.
Path: components/ui/alert-dialog.tsx
Line: 3
Comment:
import should be `@radix-ui/react-alert-dialog` not `radix-ui`
```suggestion
import { AlertDialog as AlertDialogPrimitive } from "@radix-ui/react-alert-dialog"
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: components/ui/label.tsx
Line: 3
Comment:
import should be `@radix-ui/react-label` not `radix-ui`
```suggestion
import { Label as LabelPrimitive } from "@radix-ui/react-label"
```
How can I resolve this? If you propose a fix, please make it concise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.