Skip to content

Use radix nova style#3

Merged
phev8 merged 3 commits intomainfrom
use-radix-nova-style
Feb 24, 2026
Merged

Use radix nova style#3
phev8 merged 3 commits intomainfrom
use-radix-nova-style

Conversation

@phev8
Copy link
Contributor

@phev8 phev8 commented Feb 24, 2026

No description provided.

…onfirm Dialog, Loading Button, and main registry
…ertProvider and ConfirmProvider components, and enhance README with usage examples
@greptile-apps
Copy link

greptile-apps bot commented Feb 24, 2026

Greptile Summary

This PR migrates the component registry from new-york to radix-nova style. It adds new alert and confirm dialog providers with promise-based APIs, updates the registry structure to support style-specific paths, and enhances documentation with interactive examples.

Key changes:

  • Migrated style from new-york to radix-nova in components.json
  • Added new AlertDialogProvider and ConfirmDialogProvider components with hook-based APIs
  • Added new Dialog component with i18n-friendly close button labels
  • Updated registry structure to use style-aware paths (/r/{style}/{name}.json)
  • Added TypeScript path mapping for @/components/c-ui/* with fallback to registry/radix-nova/*
  • Updated styling for alert-dialog with radix-nova design patterns
  • Enhanced README with comprehensive installation and usage instructions
  • Added interactive examples for alert, confirm, and loading button components

Issues found:

  • Four files use incorrect import syntax from "radix-ui" instead of the specific scoped packages like @radix-ui/react-slot, @radix-ui/react-dialog, etc. While radix-ui is a valid re-export package in dependencies, the correct convention is to import from the specific scoped packages.

Confidence Score: 3/5

  • This PR requires fixes to import statements before merging to avoid potential runtime issues
  • The import syntax errors in 4 files will likely cause build/runtime failures since the code imports from radix-ui package instead of the specific scoped packages. While the radix-ui package exists in dependencies, the correct convention is to use the individual scoped packages. The rest of the changes are well-structured with good additions to the component library.
  • registry/radix-nova/button.tsx, registry/radix-nova/dialog.tsx, components/ui/alert-dialog.tsx, and components/ui/label.tsx need import corrections

Important Files Changed

Filename Overview
registry/radix-nova/button.tsx New button component with incorrect import statement from radix-ui instead of @radix-ui/react-slot
registry/radix-nova/dialog.tsx New dialog component with incorrect import from radix-ui instead of @radix-ui/react-dialog
components/ui/alert-dialog.tsx Updated styling with incorrect import from radix-ui instead of @radix-ui/react-alert-dialog
components/ui/label.tsx Minor updates with incorrect import from radix-ui instead of @radix-ui/react-label
components/ui/button.tsx Changed to re-export from @/components/c-ui/button which resolves via tsconfig path mapping
tsconfig.json Added path mapping for @/components/c-ui/* with fallback to registry/radix-nova

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[components.json<br/>style: radix-nova] --> B[tsconfig.json<br/>Path Mapping]
    B --> C[Path: @/components/c-ui/*]
    C --> D[components/c-ui/*<br/>if exists]
    C --> E[registry/radix-nova/*<br/>fallback]
    
    E --> F[button.tsx]
    E --> G[alert-provider.tsx]
    E --> H[confirm-provider.tsx]
    E --> I[confirm-dialog.tsx]
    E --> J[loading-button.tsx]
    E --> K[dialog.tsx]
    
    G --> L[AlertDialogProvider<br/>useAlert hook]
    H --> M[ConfirmDialogProvider<br/>useConfirm hook]
    
    N[components/ui/button.tsx] -.re-export.-> C
    F --> N
    
    O[registry.json] --> P[public/r/radix-nova/*.json]
    P --> Q[Hosted Registry<br/>coneno.github.io]
Loading

Last reviewed commit: 4c92259

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

27 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link

greptile-apps bot commented Feb 24, 2026

Additional Comments (2)

components/ui/alert-dialog.tsx
import should be @radix-ui/react-alert-dialog not radix-ui

import { AlertDialog as AlertDialogPrimitive } from "@radix-ui/react-alert-dialog"
Prompt To Fix With AI
This is a comment left during a code review.
Path: components/ui/alert-dialog.tsx
Line: 3

Comment:
import should be `@radix-ui/react-alert-dialog` not `radix-ui`

```suggestion
import { AlertDialog as AlertDialogPrimitive } from "@radix-ui/react-alert-dialog"
```

How can I resolve this? If you propose a fix, please make it concise.

components/ui/label.tsx
import should be @radix-ui/react-label not radix-ui

import { Label as LabelPrimitive } from "@radix-ui/react-label"
Prompt To Fix With AI
This is a comment left during a code review.
Path: components/ui/label.tsx
Line: 3

Comment:
import should be `@radix-ui/react-label` not `radix-ui`

```suggestion
import { Label as LabelPrimitive } from "@radix-ui/react-label"
```

How can I resolve this? If you propose a fix, please make it concise.

@phev8 phev8 merged commit 4b0cc8c into main Feb 24, 2026
3 checks passed
@phev8 phev8 deleted the use-radix-nova-style branch February 24, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant