fix for Electron App#113
Open
ellerbrock wants to merge 1 commit intoconnors:masterfrom
ellerbrock:bugfix
Open
Conversation
|
please rebase |
bmunoz89
approved these changes
Jan 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems:
1.) running
npm startintemplate-appthrows an error that Moduleappcan't be found.Versions: - Node: 6.2.2 - npm: 3.10.3
Output:
2.) Window Setting: `'title-bar-style': 'hidden' not working. Also the Window content doesn't fit properly.
More Details can be found here: frameless-window.
Bugfix 1:
Run Electron in a frameless window and add Drag Support to class
toolbar-header.app.js:
index.html:
add:
style="-webkit-app-region: drag"Problem: In this case we can move the Window but the close, minimize and maximize buttons are missing and need to be implemented later on.
Bugfix 2:
Start Electron in a normal Window and delete the HTML toolbar.
app.js:
index.html:
delete:
Hope this help you guys. And thanks for the awesome Framework for Electron, love it! Keep up with the great work.
Cheers Maik Ellerbrock