Skip to content

Conversation

@pyramation
Copy link
Collaborator

feat(deparser): add join fixtures for pretty printing tests

Summary

Adds SQL fixtures for testing JOIN statement parsing and deparsing. These fixtures were extracted from snapshots in another repository and cleaned up (removed unnecessary quotes around column references like "t0.id"t0.id).

The fixtures cover:

  • Simple inner join
  • Left outer join
  • Multiple joins in a single query
  • Joined tables with specific column selections
  • Basic SELECT from a single table

Review & Testing Checklist for Human

  • Verify the cleaned-up SQL is what was intended - the original snapshots had quoted column references like "t0.id" which I converted to proper t0.id syntax. If you wanted to test the quoted versions to investigate a potential parser bug, those should be added separately.
  • Confirm the JOIN normalization in snapshots is expected (INNER JOINJOIN, LEFT OUTER JOINLEFT JOIN)
  • Run npm test -- --testPathPatterns="joins-pretty" in packages/deparser to verify tests pass

Notes

Add SQL fixtures for testing JOIN parsing and deparsing:
- Simple inner join
- Left outer join
- Multiple joins
- Joined tables with specific columns
- Raw ast passthrough

These fixtures help verify that JOIN statements are parsed and deparsed correctly.
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@pyramation pyramation closed this Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants