tests: some more storage.conf rewrite prep#6714
Merged
Luap99 merged 2 commits intocontainers:mainfrom Mar 11, 2026
Merged
Conversation
Because the new storage.conf parsing will always read the storage.conf file also under $HOME it means in this unshare env it tries to access /root which will not work due missing permissions. To work around set CONTAINERS_STORAGE_CONF=/dev/null to make it not parse the normal storage.conf locations here. The tests are using their own storage options via the cli anyway so this should not alter the behavior. This is need in preparation for the storage.conf rewrite[1]. [1] containers/container-libs#680 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This option is not actually used in GetStore() for anything. It only is used during config parsing in storage.conf but that is of no relevance here. Context: I remove this option for the storage.conf rework [1] and as it does not do anything we can already remove it to avoid breaking the compile for the vendor step once the upstream PR is merged. [1] containers/container-libs#680 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
dosubot
bot
added
the
size:S
Member
Author
|
@TomSweeneyRedHat @Honny1 PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
More preparation work for containers/container-libs#680, I like to get them merged in advance so the container-libs PR will not break the vendor for others once it gets merged.
Commits were tested in #6708 already.
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?