engine: add platform field to EngineConfig#669
Open
TrevorBurnham wants to merge 1 commit intocontainers:mainfrom
Open
engine: add platform field to EngineConfig#669TrevorBurnham wants to merge 1 commit intocontainers:mainfrom
TrevorBurnham wants to merge 1 commit intocontainers:mainfrom
Conversation
This was referenced Feb 24, 2026
Luap99
requested changes
Feb 25, 2026
Member
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
Thanks
Please make podman and buildah Prs to actually implement that option so we know this will work before merging here.
Also this will have to be document in the default containers.conf file as well not just the mane page
Member
|
As a general note the AI PR descriptions add nothing of value so just omit them, simply a short one sentence description with a link to the issue is enough for such a simple change |
TrevorBurnham
force-pushed
the
add-engine-platform-config
branch
from
41047e4 to
625a59a
Compare
Author
|
@Luap99 Updated, thanks! |
TrevorBurnham
added a commit
to TrevorBurnham/buildah
that referenced
this pull request
Feb 25, 2026
When no --platform, --os, --arch, or --variant flags are specified, fall back to the platform value from containers.conf [engine] section. This allows users to set a default platform for all image operations (pull, build, from) without passing flags each time. Depends on: containers/container-libs#669 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
TrevorBurnham
added a commit
to TrevorBurnham/podman
that referenced
this pull request
Feb 25, 2026
Closes: containers#25641 Add support for setting a default platform for image operations (pull, build, create, run) without requiring --platform on every command. The default platform is resolved in the following priority order: 1. Explicit --platform (or --arch/--os) flag 2. DOCKER_DEFAULT_PLATFORM environment variable 3. containers.conf [engine] platform setting 4. Host's native OS/architecture This is useful for Apple Silicon users who need linux/amd64 images, and for Docker compatibility (DOCKER_DEFAULT_PLATFORM). Depends on: containers/container-libs#669 Signed-off-by: TrevorBurnham <TrevorBurnham@users.noreply.github.com> Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
Draft
6 tasks
Author
|
I've submitted draft PRs for the downstream changes: |
Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
TrevorBurnham
force-pushed
the
add-engine-platform-config
branch
from
625a59a to
ebad6b0
Compare
TrevorBurnham
added a commit
to TrevorBurnham/buildah
that referenced
this pull request
Feb 26, 2026
Use go.podman.io/common from TrevorBurnham/container-libs#669 (add-engine-platform-config branch) to test the new engine platform config field in buildah CI. Depends on: containers/container-libs#669 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
TrevorBurnham
added a commit
to TrevorBurnham/buildah
that referenced
this pull request
Feb 26, 2026
Replace go.podman.io/common, go.podman.io/image/v5, and go.podman.io/storage with TrevorBurnham/container-libs@add-engine-platform-config to test the new engine platform config field in buildah CI. Depends on: containers/container-libs#669 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
TrevorBurnham
added a commit
to TrevorBurnham/buildah
that referenced
this pull request
Feb 26, 2026
When no --platform, --os, --arch, or --variant flags are specified, fall back to the platform value from containers.conf [engine] section. This allows users to set a default platform for all image operations (pull, build, from) without passing flags each time. Depends on: containers/container-libs#669 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
TrevorBurnham
added a commit
to TrevorBurnham/buildah
that referenced
this pull request
Feb 26, 2026
Replace go.podman.io/common, go.podman.io/image/v5, and go.podman.io/storage with TrevorBurnham/container-libs@add-engine-platform-config to test the new engine platform config field in buildah CI. Depends on: containers/container-libs#669 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
TrevorBurnham
added a commit
to TrevorBurnham/buildah
that referenced
this pull request
Feb 27, 2026
When no --platform, --os, --arch, or --variant flags are specified, fall back to the platform value from containers.conf [engine] section. This allows users to set a default platform for all image operations (pull, build, from) without passing flags each time. Depends on: containers/container-libs#669 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
TrevorBurnham
added a commit
to TrevorBurnham/buildah
that referenced
this pull request
Feb 27, 2026
Replace go.podman.io/common, go.podman.io/image/v5, and go.podman.io/storage with TrevorBurnham/container-libs@add-engine-platform-config to test the new engine platform config field in buildah CI. Depends on: containers/container-libs#669 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
Member
|
Noting that the Buildah PR passed CI testing, Podman is still red tests there. |
Member
|
Changes LGTM |
Contributor
|
(The Podman PR points at a few design questions, at this point I wouldn’t rule out that we might want to change the syntax documented in this PR. But I’l leave that to experts.) |
Author
I've rebased the branch and all checks for the PR are now passing except one, which appears to be due to a disruption in testing farm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: containers/podman#25641
This PR adds a new
platformoption to the[engine]section ofcontainers.conf:This allows users to set a default platform (of the form
os/archoros/arch/variant) for image operations.