Open
Conversation
…map types to a string value manually. `SigningAlgorithm.rawValue` will automatically contain the case identifier as string. `CaseIterable` provides `.allCases` which makes sure, we catch all available algorithms in the test. Which, to be honest now became somewhat superfluous.
…e-form text string for a parameter which is only allowed to have 2 different values.
…rid of the switch here.
…ertible`. (Even when they're not localized. You're in good company with Apple…)
…chainSigner` to `SigningAlgorithm` to improve code clarity.
…L` and removed `URL` suffix.
…using the `C2PAError.api` error.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 77.09% 80.67% +3.57%
==========================================
Files 39 46 +7
Lines 1301 1661 +360
==========================================
+ Hits 1003 1340 +337
- Misses 298 321 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
redaranj
force-pushed
the
feature/manifest-validation
branch
from
8707f7f to
1a3f755
Compare
redaranj
force-pushed
the
feature/manifest-validation
branch
from
1a3f755 to
317cb30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Types of changes
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment