Conversation
|
ale-adobe
left a comment
ale-adobe
left a comment
There was a problem hiding this comment.
Looks promising! Let me know if you'd like a more formal review and ✅ .
| @@ -0,0 +1,3 @@ | |||
| -----BEGIN PRIVATE KEY----- | |||
There was a problem hiding this comment.
Feels weird to commit the private key, but I guess we don't have many other choices. 🤔
| function str2ab(str: string): ArrayBuffer { | ||
| const buf = new ArrayBuffer(str.length); | ||
| const bufView = new Uint8Array(buf); | ||
| for (let i = 0, strLen = str.length; i < strLen; i++) { |
There was a problem hiding this comment.
nit: can we simplify?
| for (let i = 0, strLen = str.length; i < strLen; i++) { | |
| for (let i = 0, i < str.length; i++) { |
| fn direct_cose_handling(&self) -> bool { | ||
| // @TODO: make configurable | ||
| true | ||
| self.direct_cose_handling |
| expect(activeManifest.signature_info).toMatchObject({ | ||
| alg: 'Ed25519', | ||
| cert_serial_number: | ||
| '638838410810235485828984295321338730070538954823', |
There was a problem hiding this comment.
Where is this coming from?
2 participants
No description provided.