fix: Fragmented video verification#1925
Merged
gpeacock merged 4 commits intocontentauth:mainfrom Mar 12, 2026
Merged
Conversation
timmurphydev
commented
Mar 11, 2026
mauricefisher64
approved these changes
Mar 12, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
scouten-adobe
approved these changes
Mar 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This PR fixes a couple of issues with validating fragmented video.
The first is that trust cannot be configured via settings because thread_local_settings is not being passed in when creating the context in from_fragmented_files.
The second is that when validating fragmented video, the SDK is always returning a
assertion.bmffHash.mismatcherror from load_from_file_and_fragments. This is because the from_stream call results in a call to verify_store with the init segment being validated alone like a full video. The mismatch error gets accumulated here. Then ifverifyistrue, the validation will succeed on the second pass with the init segment and fragments, but the error is still present from the first pass. The fix follows the existing pattern in load_fragment_from_stream except that it destructures the result and tests remote_url, even though it is probably always None for fragmented video.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.