Skip to content

fix: Fragmented video verification#1925

Merged
gpeacock merged 4 commits intocontentauth:mainfrom
timmurphydev:fix/fragmented-video-verification
Mar 12, 2026
Merged

fix: Fragmented video verification#1925
gpeacock merged 4 commits intocontentauth:mainfrom
timmurphydev:fix/fragmented-video-verification

Conversation

@timmurphydev
Copy link
Contributor

Changes in this pull request

This PR fixes a couple of issues with validating fragmented video.

The first is that trust cannot be configured via settings because thread_local_settings is not being passed in when creating the context in from_fragmented_files.

The second is that when validating fragmented video, the SDK is always returning a assertion.bmffHash.mismatch error from load_from_file_and_fragments. This is because the from_stream call results in a call to verify_store with the init segment being validated alone like a full video. The mismatch error gets accumulated here. Then if verify is true, the validation will succeed on the second pass with the init segment and fragments, but the error is still present from the first pass. The fix follows the existing pattern in load_fragment_from_stream except that it destructures the result and tests remote_url, even though it is probably always None for fragmented video.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@timmurphydev timmurphydev changed the title Fix/fragmented video verification fix/fragmented video verification Mar 11, 2026
@timmurphydev timmurphydev changed the title fix/fragmented video verification fix: fragmented video verification Mar 11, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing timmurphydev:fix/fragmented-video-verification (0df6937) with main (072c04f)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@scouten-adobe scouten-adobe changed the title fix: fragmented video verification fix: Fragmented video verification Mar 12, 2026
@gpeacock gpeacock merged commit 7144c42 into contentauth:main Mar 12, 2026
26 checks passed
@caiopensrc caiopensrc mentioned this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants