*: fix assignments to make the new version of ineffassign happy#455
Merged
erikh merged 1 commit intocontiv-experimental:masterfrom Sep 2, 2016
dseevr:ineffassign_fix
Merged
*: fix assignments to make the new version of ineffassign happy#455erikh merged 1 commit intocontiv-experimental:masterfrom dseevr:ineffassign_fix
erikh merged 1 commit intocontiv-experimental:masterfrom
dseevr:ineffassign_fix
Conversation
Contributor
|
oh, this is because ineffassign got bug fixes in IT that caused it to detect new ones. I ran into this the other night preparing the DB patch. |
Contributor
Author
|
Ahh, that explains... and because we have to invoke ineffassign once for each dir, it was just bailing on the first error. Do you want me to tidy up all the spots it's complaining about and update the PR? |
Signed-off-by: Bill Robinson <dseevr@users.noreply.github.com>
dseevr
changed the title
Contributor
|
If you don't mind; yeah. |
Contributor
Author
|
Done and passing |
Contributor
|
hmm; I made several of these fixes already in the db patch but I guess I can rebase them out |
Contributor
|
LGTM. Simple enough that I'm just going to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes all the issues which the new version of ineffassign is complaining about.