Skip to content

Add a typed exception for 403 errors. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
woodhull wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a typed exception for 403 errors. #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/action_network_rest/response/raise_error.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ def on_complete(response)
if error_message == 'You must specify a valid person id'
raise MustSpecifyValidPersonId, error_message(response)
end
elsif status_code == 403
raise AuthorizationError, error_message(response)
elsif status_code == 404
raise NotFoundError, error_message(response)
elsif status_code == 429
Expand All @@ -31,6 +33,8 @@ def error_message(response)
end
end

class AuthorizationError < StandardError; end

class MissingActionNetworkId < StandardError; end

class MustSpecifyValidPersonId < StandardError; end
Expand Down
7 changes: 7 additions & 0 deletions spec/response/raise_error_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@
.to(raise_error(ActionNetworkRest::Response::MustSpecifyValidPersonId, /You must specify a valid person id/))
end


it 'should raise AuthorizationError if status is 403' do
response = { status: '403', body: { error: 'API Key invalid or not present' }.to_json }

expect { subject.on_complete(response) }.to raise_error(ActionNetworkRest::Response::AuthorizationError, /API Key invalid/)
end

it 'should raise NotFoundError if status is 404' do
response = { status: '404', body: { error: 'Not found' }.to_json }

Expand Down