Skip to content

Conversation

@nickbrowne
Copy link
Contributor

To test, run the various npm scripts which use different parts of the cakefile:

npm run build
npm run test
npm run prepublish

None should give any errors or any build output changes.

@mattptc
Copy link

mattptc commented Nov 14, 2024

I get a test failure on the branch and on main.
Followed the README and created the db. Test still failed.
Also tried with an older version of node.

FAILURES: Undone tests (or their setups/teardowns):
- db - pg - create doesnt send an error when a document is created

@nickbrowne
Copy link
Contributor Author

I get a test failure on the branch and on main.
Followed the README and created the db. Test still failed.
Also tried with an older version of node.

You might just need to createdb sharejs_example if you haven't already, slight gotcha

@mattptc
Copy link

mattptc commented Nov 15, 2024

I had to comment out the db host in options.js

// host: "/var/run/postgresql",

That probably works on Linux but the socket on MacOS must be different. The default seems to work.

@nickbrowne
Copy link
Contributor Author

That probably works on Linux but the socket on MacOS must be different. The default seems to work.

Ah yep, good to know.

@nickbrowne nickbrowne merged commit a7733ae into master Nov 15, 2024
1 check passed
@nickbrowne nickbrowne deleted the 18363-upgrade-shelljs branch November 15, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants