feat(gallery): добавлена возможность скрывать кнопку поделиться#1956
Open
DavidGuryanov wants to merge 24 commits intocore-ds:masterfrom
Open
feat(gallery): добавлена возможность скрывать кнопку поделиться#1956DavidGuryanov wants to merge 24 commits intocore-ds:masterfrom
DavidGuryanov wants to merge 24 commits intocore-ds:masterfrom
Conversation
DavidGuryanov
requested review from
SiebenSieben,
dHIM24,
fulcanellee and
hextion
as code owners
🦋 Changeset detectedLatest commit: 9e0a664 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 20958106631Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
* fix(universal-date-input): изменить dateValue на dateTime * Update polite-drinks-cross.md * Update polite-drinks-cross.md
* fix(bottom-sheet): prevent scroll on swipe * fix(bottom-sheet): prevent scroll on swipe * Update six-ears-rush.md * fix(bottom-sheet): prevent scroll on swipe
* feat(icon-button): change dir * feat(icon-button): types change dir * feat(icon-button): rename icon-button to base-icon-button * feat(icon-button): base-icon-button by client * feat(icon-button): add icon-button-desktop * feat(icon-button): add icon-button-mobile * feat(icon-button): add icon-button-responsive * feat(icon-button): add story * feat(icon-button): add desktop screenshots * feat(icon-button): add mobile screenshots * feat(icon-button): change border-radius for desktop/mobile, remove corp vars * feat(icon-button): update screenshots * feat(icon-button): add changeset * feat(icon-button): prop types to interface
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix(textarea): improve right addon position * fix(textarea): update screenshots
* feat(universal-modal): update screenshots * feat(universal-modal): update screenshots * feat(universal-modal): remove unnecessary styles * feat(universal-modal): improve styles * feat(universal-modal): fix trim styles * feat(universal-modal): improve screenshot tests * feat(universal-modal): update screenshots * feat(universal-modal): improve styles * feat(universal-modal): update screenshots * feat(universal-modal): update screenshots * feat(universal-modal): update screenshots * feat(universal-modal): revert * feat(universal-modal): revert * feat(navigation-bar-private): fix trim styles * feat(universal-modal): update screenshots * feat(navigation-bar-private): add changeset * feat(universal-modal): add changeset * feat(universal-modal): tune screenshots
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…S-14351] (core-ds#1995) * feat(Confirmation): Добавить пропсу для max-width мобильной версии [DS-14351] * CodeReview
…ore-ds#1998) * fix(universal-modal): исправить специфичность компонента [DS-13773] * Update salty-berries-shave.md
* fix(select): update screenshots * fix(select): fix responsive search in option list * fix(select): update screenshots * fix(select): fix scroll responsive logic in option list * fix(select): update screenshots * fix(select): update screenshots * fix(select): update screenshots * fix(select): update screenshots * fix(select): fix scroll responsive logic in virtual option list * fix(select): update screenshots * fix(select): add changeset * fix(select): update screenshots * fix(select): update changeset * fix(select): update screenshots * Revert "fix(select): update screenshots" This reverts commit 347f7aa.
…ьной клавиатуры [DS-14173] (core-ds#1983) * feat(base-modal): Заблокировать скролл страницы при появлении виртуальной клавиатуры * CodeReview * CodeReview * CodeReview, fix description
…ля его стилизации [DS-14590] (core-ds#2002) * feat(bottom-sheet): Добавлен слот outerAddons и проп outerClassName для его стилизации * CodeReview * add comment and fix esLint * fix esLint
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
@Oladii @temss-front посмотрите пожалуйста |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Раньше можно было скрывать только кнопку "скачать". Теперь, после моей инновационной доработки, можно скрывать ещё и кнопку "поделиться".
Во-первых, это добавляет гибкости компоненту.
Во-вторых, в некоторых вебвью не работает navigator.share, так что эта кнопка не будет работать, соответсвенно её надо скрывать от пользователя.
Чек лист
Если есть визуальные изменения