Skip to content

feat(cdn-icon): валидация некорректных названий [DS-14485]#2022

Open
dHIM24 wants to merge 6 commits intomasterfrom
DS-14485
Open

feat(cdn-icon): валидация некорректных названий [DS-14485]#2022
dHIM24 wants to merge 6 commits intomasterfrom
DS-14485

Conversation

@dHIM24
Copy link
Contributor

@dHIM24 dHIM24 commented Jan 22, 2026

CDNIcon

  • Добавлена валидация имени иконки для предотвращения загрузки невалидных значений

Чек лист

  • Задача сформулирована и описана в JIRA
  • В названии ветки есть айдишник задачи в JIRA (fix/DS-1234), ссылку прикреплять не надо
  • У реквеста осмысленное название feat(...) или fix(...) по conventional commits (https://www.conventionalcommits.org)
  • Код покрыт тестами и протестирован в различных браузерах
  • Добавленные пропсы добавлены в демки и описаны в документации
  • К реквесту добавлен changeset

Если есть визуальные изменения

  • Прикреплено изображение было/стало
2026-02-06.11.22.36.mov

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2026

🦋 Changeset detected

Latest commit: 193b2ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@alfalab/core-components-cdn-icon Minor
@alfalab/core-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Jan 22, 2026

Pull Request Test Coverage Report for Build 21747959707

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 20 of 22 (90.91%) changed or added relevant lines in 3 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 77.035%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/cdn-icon/src/hooks/use-icon.ts 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
packages/select/src/utils.ts 12 73.28%
Totals Coverage Status
Change from base Build 21710657089: 0.001%
Covered Lines: 9603
Relevant Lines: 11624

💛 - Coveralls

@github-actions
Copy link
Contributor

Demo build

https://core-ds.github.io/core-components/2022

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Demo build (default)

https://core-ds.github.io/core-components/2022-default

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Demo build (alfasans)

https://core-ds.github.io/core-components/2022-alfasans

@dHIM24 dHIM24 marked this pull request as ready for review February 6, 2026 08:32
Co-authored-by: fulcanellee <45999900+fulcanellee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants