dracut/30ignition/module-setup.sh: include groupmod binary in initramfs

[onurhanak]

Resolves #2186 . Adds groupmod binary to initramfs for the changes made in pull request #2158 to work.

[gemini-code-assist]

Code Review

This pull request correctly adds the groupmod binary to the initramfs, which is necessary for related changes. The PR also includes several stylistic improvements, such as code formatting and indentation fixes. I have one suggestion to further improve the readability and robustness of the install_ignition_unit function by simplifying its argument parsing.

[gemini-code-assist]

While you're refactoring this for style, you can simplify the argument parsing. Using positional parameters directly ($1, $2, etc.) is clearer and less prone to errors than using shift multiple times, especially if set -e were active and the function was called with fewer arguments than expected.

Suggested change

	local unit="$1"
	shift
	local target="${1:-ignition-complete.target}"
	shift
	local instantiated="${1:-$unit}"
	shift
	local unit="$1"
	local target="${2:-ignition-complete.target}"
	local instantiated="${3:-$unit}"

[onurhanak]

Hi, @prestist. Is there an approximate timeline as to when this PR can be merged? Thank you.

[prestist]

@onurhanak thank you for working on this! sorry I had been busy on other tasks and this slipped my radar. I will take a look tomorrow.

[onurhanak]

Hi @prestist , is there any progress on this? Is there anything I can do to speed things up?

[prestist]

Firstly, I am so sorry about the delay between PR and review here. Thank you
for working on this — adding the groupmod binary to the module setup makes
sense and fixes the issue correctly.

The formatting changes are not really part of this PR however. I'm okay
including them, but they should be in a separate commit to keep the
functional change (adding groupmod) distinct from the stylistic changes
(indentation fixes). I've added specific comments below.

Thank you again! Once we split those commits, this should be good to go.

[prestist]

Hmm, between this formatting change and the "shift" changes above, I think we can keep the formatting the same or make it an intentional commit along so that functional and stylistic choices are separated.

[onurhanak]

@prestist Thanks, I edited my PR.

[prestist]

LGTM! thank you for working on this!