This repository was archived by the owner on Sep 21, 2023. It is now read-only.
made vault-operator track vault upstream image, upgrade and enable ui#328
Open
dhrp wants to merge 1 commit intocoreos:masterfrom
Open
made vault-operator track vault upstream image, upgrade and enable ui#328dhrp wants to merge 1 commit intocoreos:masterfrom
dhrp wants to merge 1 commit intocoreos:masterfrom
Conversation
By installing curl into the vault image at initialization, we don't need to have a customized vault image, and can track upstream. This commit also upgrades to vault 0.10.2 and enables the (new) ui closes coreos#290
|
How did you @dhrp compile the vault-operator after this mods ? |
|
For people searching for how to enable the vault ui, instead of this PR you can use a ConfigMap: and point vault-operator service using spec.configMapName: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By installing curl into the vault image at initialization, we don't need to have a customized vault image, and can track upstream.
This also upgrades to vault 0.10.2 and enables the (new) ui
closes #290
considerations:
This does mean that vault will install cURL from the configured apk repositories at initialization time, which makes it less suitable for an air-gapped cluster. On the flipside, those clusters can probably not use the operator anyway.
If you look closely I've reversed the (logical) order at sh -c to first drop the capabilities, then install curl, en then launch. This is because otherwise, the OS would somehow still be modifying the /bin/vault while it was being launched, causing a "text file busy" (modifying running executable) error.
credits to @kesselborn for suggesting this approach.