Add support to filter out comments#30
Open
KamarajuKusumanchi wants to merge 5 commits intocosmocode:masterfrom
Open
Add support to filter out comments#30KamarajuKusumanchi wants to merge 5 commits intocosmocode:masterfrom
KamarajuKusumanchi wants to merge 5 commits intocosmocode:masterfrom
Conversation
splitbrain
requested changes
Oct 17, 2025
Member
splitbrain
left a comment
splitbrain
left a comment
There was a problem hiding this comment.
This is not really standards compatible and thus should probably be disabled by default. To be enabled via the syntax.
The change should also be accompanied by tests.
Author
|
Both comments (making this functionality as optional and adding test cases) are valid. But I am not very knowledgeable about php and also have limited time to look into this. I would appreciate if some kind soul can address these two issues. Please let me know if I should delete this MR or leave it open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will address #29 by replacing lines starting with '#' (even with leading whitespace) with an empty string, effectively removing the line.