feat(mempool): incremental recheck #909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
swift1337
reviewed
Dec 17, 2025
…mpletion) and into a seperate Cancel function
swift1337
reviewed
Dec 19, 2025
mattac21
force-pushed
the
ma/incremental-recheck
branch
from
3c991da to
392848e
Compare
mattac21
force-pushed
the
ma/incremental-recheck
branch
from
b8e1b2b to
9134baf
Compare
mattac21
force-pushed
the
ma/incremental-recheck
branch
2 times, most recently
from
e87dacf to
9134baf
Compare
| dirtyAccounts: dirtyAccounts, | ||
| events: queuedEvents, | ||
| } | ||
| go pool.runReorg(input) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the ability for proposals to be created out of txs in the pending pool while the pool is resetting via a new block. Previously, this resetting would hold the lock on the pool for the entire duration of the reset, which would need to call recheck on every tx in the pending pool. This may take multiple seconds, which will block a call to
Pendingand therefore blockPrepareProposal.This PR addresses this by pushing txs into a
txCollectoras they are validated viademoteUnexecutables. Creating a 'snapshot' of the pending txs that have been validated for a height at any given time. This snapshot no longer shares the same global legacypool lock, thus unblockingPrepareProposal's call toPending.This PR also adds functionality where the reorg loop will be cancelled if it is still processing a reset (new block seen), and a new block arrives. This is to prevent the case where
demoteUnexecutablestakes such a long time to process txs that processing the previous height, always takes longer than the timeout the caller is willing to wait inPending, thus preventing any txs from ever making it into a proposal.Closes: STACK-2008
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch