update the const LDAPAuthDomain to have type AuthDomain#5
Open
tx0c wants to merge 1 commit intocouchbase:masterfrom
Open
update the const LDAPAuthDomain to have type AuthDomain#5tx0c wants to merge 1 commit intocouchbase:masterfrom
tx0c wants to merge 1 commit intocouchbase:masterfrom
Conversation
https://play.golang.org/p/_vp5ROMdP6f ```go fmt.Printf("%[1]T %#[1]v\n", InternalAuthDomain) fmt.Printf("%[1]T %#[1]v\n", LDAPAuthDomain) ``` runs ``` main.AuthDomain "local" string "ldap" ```
ns-codereview
pushed a commit
that referenced
this pull request
Nov 19, 2019
https://play.golang.org/p/_vp5ROMdP6f ```go fmt.Printf("%[1]T %#[1]v\n", InternalAuthDomain) fmt.Printf("%[1]T %#[1]v\n", LDAPAuthDomain) ``` runs ``` main.AuthDomain "local" string "ldap" ``` Change-Id: Idc693a26cb3a0f31643d3966f5e2bfd7ac282525 Reviewed-on: http://review.couchbase.org/118145 Tested-by: Build Bot <build@couchbase.com> Reviewed-by: Tommie McAfee <tommie@couchbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in a const section, each new const does not inherit previous line's type;
https://play.golang.org/p/_vp5ROMdP6f
runs