fix(atomic): accessibility fixes for commerce and recommendation components#7112
Draft
fix(atomic): accessibility fixes for commerce and recommendation components#7112
Conversation
…onents - Add aria-live announcements to commerce pager for page changes - Add unique aria-label to commerce refine modal - Fix nested interactive elements in suggestion renderer (button -> div) - Update e2e test assertions for better accessibility violation reporting
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| }, | ||
| })( | ||
| renderRefineModalBody()(html` | ||
| renderRefineModalBody(this.bindings.i18n)(html` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies accessibility fixes to commerce and recommendation components extracted from the
accessibility-epic2branch.Changes Applied
Source Commits
Applied fixes from the following commits on
accessibility-epic2:Files Changed
Testing
Notes
This is part of the larger a11y cleanup effort. Changes were manually applied rather than cherry-picked due to significant structural differences between branches.