fix(atomic): accessibility fixes for common and search components#7115
Draft
fix(atomic): accessibility fixes for common and search components#7115
Conversation
- Added unique aria-labels to aside elements in generated-answer components - Updated refine-modal body to accept and use aria-label via i18n - Added aria-labels to smart-snippet components - Updated atomic-refine-modal to pass aria-label to RefineModalBody Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)
…5ef4bf9, 75b21af, 7135cf5, c3acb1f) Multiple a11y improvements: - Search box announces clear action to screen readers - Breadcrumb button improved aria-label handling - Text area clear button enhanced accessibility - Query summary aria-live messages improved - Pager buttons add announcements for page navigation - Radio button group accessibility enhancements - Atomic suggestion renderer fixed nested interactive elements Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)
…b843ee) Added localized strings for: - refine-modal-content - user-actions-content - search-box-cleared - pager navigation announcements - and other a11y-related UI labels Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts accessibility fixes for
common/andsearch/components from the accessibility-epic2 branch. This PR is part of the a11y-cleanup-and-extraction effort (Task 5 of 8).Source Commits
All changes extracted from accessibility-epic2 branch:
Changes Included
Landmarks & ARIA Labels
aria-labelattributes to all aside elements (generated-answer, smart-snippets, refine-modal)Search Box
Pager
Breadbox
Other
Files Changed
src/components/common/- 11 files (generated-answer, refine-modal, smart-snippets, breadbox, search-box, pager, radio-button, suggestion-renderer)src/components/search/- 4 files (refine-modal, results-per-page, search-box, pager)src/locales.json- 380 lines added (all a11y-related locale strings)Verification
Related
a11y-cleanup-and-extractionplan