Skip to content

feat(atomic): wire VitestA11yReporter into storybook vitest project#7126

Closed
y-lakhdar wants to merge 4 commits intofeat/a11y-scriptsfrom
feat/a11y-reporter-wiring
Closed

feat(atomic): wire VitestA11yReporter into storybook vitest project#7126
y-lakhdar wants to merge 4 commits intofeat/a11y-scriptsfrom
feat/a11y-reporter-wiring

Conversation

@y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar commented Feb 16, 2026

Context

Bridges the reporter implementation (PR #7123) and the CI integration (PR #7117) by wiring VitestA11yReporter into the packages/atomic storybook vitest project.

Try it

pnpm --filter @coveo/atomic run test:storybook

View the json report in packages/atomic-a11y/reports/a11y-report.json

PR Chain (6 of 7)

# PR Branch Description
1 #7111 feat/a11y-package-scaffold Package scaffolding
2 #7122 feat/a11y-shared-foundation Shared types, constants, utilities
3 #7123 feat/a11y-reporter VitestA11yReporter
4 #7124 feat/a11y-openacr OpenACR report generator
5 #7125 feat/a11y-scripts CLI scripts
6 #7126 feat/a11y-reporter-wiring Wire reporter into atomic vitest config ← this PR
7 #7117 feat/a11y-ci-integration Weekly a11y scan workflow

Add @coveo/atomic-a11y as a dev dependency and configure VitestA11yReporter
as a reporter in the storybook vitest project. When test:storybook runs,
the reporter captures axe-core a11y results from each story test and writes
an aggregated JSON report to packages/atomic-a11y/reports/a11y-report.json.
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2ffd50a50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"@coveo/atomic-legacy": "workspace:*"
},
"devDependencies": {
"@coveo/atomic-a11y": "workspace:*",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate lockfile after adding atomic-a11y dependency

Adding @coveo/atomic-a11y in packages/atomic/package.json without a matching pnpm-lock.yaml update will break installs in CI: the setup action runs pnpm install --frozen-lockfile (.github/actions/setup/action.yml:41), and the packages/atomic importer in the current lockfile still has no @coveo/atomic-a11y entry, so pnpm will treat the lockfile as stale and fail before tests execute.

Useful? React with 👍 / 👎.

@y-lakhdar
Copy link
Contributor Author

Closing — the wiring changes (vitest.config.js + package.json) have been folded into PR #7123 (commit feat(atomic): wire VitestA11yReporter into storybook test config).

The PR chain is now 6 PRs instead of 7. PR #7117 (feat/a11y-ci-integration) should rebase onto feat/a11y-scripts instead of feat/a11y-reporter-wiring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant