feat(atomic): wire VitestA11yReporter into storybook vitest project#7126
feat(atomic): wire VitestA11yReporter into storybook vitest project#7126y-lakhdar wants to merge 4 commits intofeat/a11y-scriptsfrom
Conversation
Add @coveo/atomic-a11y as a dev dependency and configure VitestA11yReporter as a reporter in the storybook vitest project. When test:storybook runs, the reporter captures axe-core a11y results from each story test and writes an aggregated JSON report to packages/atomic-a11y/reports/a11y-report.json.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2ffd50a50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@coveo/atomic-legacy": "workspace:*" | ||
| }, | ||
| "devDependencies": { | ||
| "@coveo/atomic-a11y": "workspace:*", |
There was a problem hiding this comment.
Regenerate lockfile after adding atomic-a11y dependency
Adding @coveo/atomic-a11y in packages/atomic/package.json without a matching pnpm-lock.yaml update will break installs in CI: the setup action runs pnpm install --frozen-lockfile (.github/actions/setup/action.yml:41), and the packages/atomic importer in the current lockfile still has no @coveo/atomic-a11y entry, so pnpm will treat the lockfile as stale and fail before tests execute.
Useful? React with 👍 / 👎.
|
Closing — the wiring changes ( The PR chain is now 6 PRs instead of 7. PR #7117 ( |
Context
Bridges the reporter implementation (PR #7123) and the CI integration (PR #7117) by wiring
VitestA11yReporterinto thepackages/atomicstorybook vitest project.Try it
View the json report in
packages/atomic-a11y/reports/a11y-report.jsonPR Chain (6 of 7)
feat/a11y-package-scaffoldfeat/a11y-shared-foundationfeat/a11y-reporterfeat/a11y-openacrfeat/a11y-scriptsfeat/a11y-reporter-wiringfeat/a11y-ci-integration